url: fix isURL detection by checking path

Fixes: nodejs/node#48921 PR-URL: nodejs/node#48928 Backport-PR-URL: nodejs/node#50105 Fixes: getsentry/sentry-javascript#8552 Fixes: request/request#3458 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
sercher · Apr 25, 2024 · 39ddf70 · 39ddf70
1 parent be42fed
commit 39ddf70
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/graal-nodejs/test/parallel/test-url-is-url.js b/graal-nodejs/test/parallel/test-url-is-url.js
@@ -9,3 +9,8 @@ const { isURL } = require('internal/url');
 
 assert.strictEqual(isURL(new URL('https://www.nodejs.org')), true);
 assert.strictEqual(isURL(parse('https://www.nodejs.org')), false);
+assert.strictEqual(isURL({
+  href: 'https://www.nodejs.org',
+  protocol: 'https:',
+  path: '/',
+}), false);