Fix excessive client connection creation #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonsinth
reviewed
May 31, 2023
| period *= 2 | ||
| } else { | ||
| period = initialPeriod | ||
| } |
There was a problem hiding this comment.
this seems.... odd to me. Am I reading this right? This seems like it would wait:
1s, 2s, 4s, 8s, 16s, 1s, 2s, 4s, 8s, 16s, 1s, 2s, 4s, 8s, 16s....
There was a problem hiding this comment.
Generally when I write things like this, what you want is some signal of success or failure from f(). As long as f errors you backoff from initial -> max. Whenever f succeeds you reset back to initial. A reasonable signal in this particular case might be "If I got an EOF that was a successful connection that terminated eventually; if I got a different kind of error that was a failure to connect"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR description discusses an issue where each RPC request calls ResolveNow. Due to incorrect handling of this event, a new connection is created for every request. As concurrency increases, so does the number of required connections, leading to timeouts on both the client and server sides when establishing connections.