-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Dev Containers #51
Conversation
Nice work! Please, create an isssue upstream and link it in the Sequent Development Board (SDB) or link to the existing issues upsteam in the SDB to track them:
|
Just for the record, I want to write here some issues to be resolved later and improvements that can be made, maybe we could also create tracking tickets for those:
As these are a lot of small things, maybe we should group them in a tracking issue that links to them together with the issues upstream, and add only this parent tracking issue to our Github Projects. |
@edulix I've created the tracking issue in SDB. |
Parent issue: https://github.com/sequentech/meta/issues/8
This PR configures a dev container for the project. The main idea is to make it easy to start developing the project.
Our initial objective was to always use an x86_64 environment, but apparently this isn't possible in aarch64 architectures yet. Another option was to use x86_64 by using Github Codespaces but Codespaces doesn't support Nix yet. So we decided to use docker images that use the same architecture as the host.
We wanted to use the nix-devcontainer project/docker image as a base but the image is not configured for aarch64 systems either so I used their code as a base to create our Dockerfile. In the future we can use nix-devcontainer if they add aarch64 support or we can define our own reusable docker container in multiple projects.
As we normally develop on M1 machines, we wanted to add a github action that runs an aarch64 machine, but there are no github-hosted m1 machines yet (it's on their roadmap though).
We haven't configured git commits to enable signing from the dev container, but as it doesn't work on Codespaces yet you can do it from a local terminal.
Changes
NixOS/nixpkgs
version and flake.lock to avoid broken openssl package.pkgs.binaryen
to the flake dev shell to fix issue on dev container.