Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions to rcl wrapper #106

Merged

Conversation

tobiasstarkwayve
Copy link
Contributor

This adds a few minor asserts and improvements to the RCL layer. Specifically:

  1. It adds a few null checks in the graph introspection code. Introspection is not particularly performance-critical, I suspect that it's worthwhile to add these checks rather than risk undefined behaviour
  2. It changes the data copies in the vector-copying code from copy to copy_nonoverlapping. There is no reason not to do it and it might provide a slight speedup.

@tobiasstarkwayve tobiasstarkwayve force-pushed the add-assertions-to-rcl-wrapper branch from 511e1b1 to c8b5e95 Compare October 8, 2024 15:32
@tobiasstarkwayve tobiasstarkwayve marked this pull request as ready for review October 8, 2024 15:33

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tobiasstarkwayve tobiasstarkwayve force-pushed the add-assertions-to-rcl-wrapper branch from c8b5e95 to d2aa689 Compare October 9, 2024 07:47
@tobiasstarkwayve
Copy link
Contributor Author

@m-dahl I just realised that I forgot to ping you here. Could you take a look at this minor change in the RCL bindings?

@m-dahl m-dahl merged commit 94ceec8 into sequenceplanner:master Oct 12, 2024
7 checks passed
@m-dahl
Copy link
Collaborator

m-dahl commented Oct 12, 2024

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants