Drop support for node <12 #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@papb I'd like to do a major release of umzug v3. Theoretically it would be nice if some work was done to make sequelize-cli and umzug play nice together. But the API and CLI are both pretty stable (I've been using v3 beta in production at work for the best part of a year). There's no reason sequelize-cli shouldn't be able to use the API. It's not like we can't go to v4 if we find there's an absolutely essential breaking change.
But before releasing v3, I think we should drop node 10. We'll be releasing in 2021, nobody should be on node 10 anymore (and if they are, they can just use umzug v2. They clearly like ancient tools).