-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: jest #215
refactor: jest #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. I like how the amount of changes was quite small. Nice work!
I am in favor of all follow-ups you mentioned!! P.S.: I will try to look at your PRs faster now. Sorry about that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had just approved your PR, but I decided to merge #208 first, otherwise I would have to ask the contributor to refactor his test once again, and I got worried this might make him upset. So instead I would like to ask you to reapply your codemod to convert his test to jest as well. I hope you don't mind :)
(by the way, he added a serial test, which is not ideal but I decided to accept anyway because a parallel test would require usage of another file for json storage, and I didn't want to add this extra "cognitive load" to that PR. If you feel like refactoring in order to make it parallel, please do, but it can wait to be done in the future as well) |
Does jest run tests serially or in parallel? Since Umzug uses |
Jest runs test files in parallel, but individual tests within the file serially: jestjs/jest#6957 To run tests within a file in parallel, there's |
Ready to merge 🚀 |
This migrates from ava to jest. The PR keeps the existing ava tests/assertions exactly as they are, but as follow-ups, we can:
jest.fn()
to make logging assertions (and dropsinon
as a dependency)lib/src/index.js
tolib/index.js
etc.