Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Super refactor #206

Merged
merged 11 commits into from
Mar 29, 2020
Merged

Super refactor #206

merged 11 commits into from
Mar 29, 2020

Conversation

papb
Copy link
Member

@papb papb commented Mar 29, 2020

  • Drop support for Node <10
  • Drop babel and coffee-script from devDependencies
  • Several other improvements

@papb papb merged commit 849d3c0 into master Mar 29, 2020
@papb papb deleted the super-refactor branch March 29, 2020 17:28
@papb
Copy link
Member Author

papb commented Mar 29, 2020

Note: removing Babel entirely might look like a breaking change but it's not really. Although we did have tests which were supposed to cover the ability of umzug to operate on JS files using the ES6 module syntax, these tests were actually misleading because they only worked since we happened to have @babel/register in our own devDependencies.

@papb
Copy link
Member Author

papb commented Mar 29, 2020

Also coffee-script support was dropped because this "support" was actually built upon a npm package that has been deprecated and has no releases for three years. It was a small price to pay to allow easier refactoring that will be coming soon. Thanks for understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@papb