Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'runs view' user permissions #372

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix 'runs view' user permissions #372

merged 2 commits into from
Dec 19, 2023

Conversation

JaimeSeqLabs
Copy link
Contributor

Description

Closes #371

Changes the endpoint used by the view cmd allowing users with 'view' role to describe workflow launches as needed by the cmd implementation.

Guidelines for testing

  • As user A in a workspace Wsp:
    • Create a pipeline and run it
    • Get the run ID
    • Give user B 'view' role for the workspace
  • As user B:
    • Confirm using web UI that workspace Wsp runs are visible
    • Configure tower access token for tw-cli
    • View run in Wsp using tw-cli:
$> ./tw runs view -i <runID> -w Org/Wsp

Expected output:


  Run at [Org / Wsp] workspace:


    General
    ---------------------+------------------------------------------
     ID                  | ggCxlvsF8Ao9I                            
     Operation ID        | 626f46be-1715-4e64-a20e-a3cd34818039     
     Run name            | pedantic_mcnulty                         
     Status              | SUCCEEDED                                
     Starting date       | Thu, 18 May 2023 09:47:13 GMT            
     Commit ID           | 1d71f857bb64af58716575d770ef74baf21313d1 
     Session ID          | ac254f00-d6d8-4d40-bf99-0ec5252ba8e5     
     Username            | jaime-munoz                              
     Workdir             | s3://jaime-testing/scratch/ggCxlvsF8Ao9I 
     Container           | quay.io/nextflow/bash                    
     Executors           | awsbatch                                 
     Compute Environment | deleted-12042873637099533                
     Nextflow Version    | 23.04.1                                  
     Labels              | No labels reported in workspace          


@JaimeSeqLabs JaimeSeqLabs linked an issue Dec 13, 2023 that may be closed by this pull request
@JaimeSeqLabs JaimeSeqLabs self-assigned this Dec 13, 2023
@JaimeSeqLabs JaimeSeqLabs marked this pull request as ready for review December 13, 2023 13:06
@JaimeSeqLabs JaimeSeqLabs merged commit 6c74a50 into master Dec 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View users unable to use 'tw runs view -i [id]'
3 participants