Gwright99/87 streamline number of locals #112
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beginning tfvars configuration check. ----- Verifying TFVARS file ----- ----- Verifying Tower configurations ----- ----- Verifying AWS Integrations ----- Retrieving subnet information from AWS Account. `sg_egress_eice` allows egress everywhere. Consider tightening. `sg_egress_tower_ec2` allows egress everywhere. Consider tightening. `sg_egress_tower_alb` allows egress everywhere. Consider tightening. `sg_egress_batch_ec2` allows egress everywhere. Consider tightening. `sg_egress_interface_endpoint` allows egress everywhere. Consider tightening. ----- Verifying Database settings ----- Your EC2 AMI will update as newer images are available. This means your VM will occasionally be destroyed and recreated. Your docker db container will destroyed when you EC2 AMI is updated. Ensure this fits your intention. You have not enabled Deletion Protection on your external DB. This is HIGHLY recommended for Production instances. If you want this, set `db_deletion_protection` to true. You have disabled a final snapshot of your external DB. Enablement of this feature is recommended for Production. Finished tfvars configuration check.
|
Note to self: Don't forget need to make it very clear in documentation that the buffered logger needs to be used with the external python scripts, since the normal logger emits to stdout and TF thinks this is the response from the Normal logger will cause errors like: │ Error: Unexpected External Program Results
│
│ with data.external.generate_db_connection_string,
│ on 000_main.tf line 66, in data "external" "generate_db_connection_string":
│ 66: program = ["python3", "${path.module}/.githooks/data_external/generate_db_connection_string.py"]
│
│ The data source received unexpected results after executing the program.
│
│ Program output must be a JSON encoded map of string keys and string values.
│
│ If the error is unclear, the output can be viewed by enabling Terraform's logging at TRACE level. Terraform documentation on logging: https://www.terraform.io/internals/debugging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating draft PR for comments.
I feel like this is a good pattern to implement but am worried about the difficulty of backing it out if I'm wrong so I'm going to be a coward and wait on it for awhile.