[FIX] Relax sequence_file_input_traits #3128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explicitly_convertible_to<typename t::sequence_legal_alphabet, typename t::sequence_alphabet>
is meant for allowing, e.g.:but not stuff like
However, this constraint is also checked for
using sequence_alphabet = char
. Our alphabets are not (explicitly/implicitly) convertible to char.The rationale of the alphabets being compatible doesn't apply for
sequence_alphabet = char
, so we should just allow it.means: Only allow characters of
seqan3::dna4
, but store them aschar
.