Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Redundant move #3095

Merged
merged 1 commit into from
Nov 7, 2022
Merged

[FIX] Redundant move #3095

merged 1 commit into from
Nov 7, 2022

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Nov 5, 2022

Occurs on gcc 13

See https://cdash.seqan.de/viewBuildError.php?buildid=11951

E.g.,

include/seqan3/io/views/detail/take_exactly_view.hpp:258:107: error: redundant move in return statement [-Werror=redundant-move]
  258 |     constexpr basic_iterator(base_base_t const & it) noexcept(noexcept(base_t{it})) : base_t{std::move(it)}
      |                                                                                                           ^
include/seqan3/io/views/detail/take_exactly_view.hpp:258:107: note: remove ‘std::move’ call

@vercel
Copy link

vercel bot commented Nov 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
seqan3 ✅ Ready (Inspect) Visit Preview Nov 5, 2022 at 7:12PM (UTC)

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 5, 2022
@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 98.22% // Head: 98.22% // No change to project coverage 👍

Coverage data is based on head (df496c8) compared to base (1bebb2c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3095   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files         275      275           
  Lines       12203    12203           
=======================================
  Hits        11987    11987           
  Misses        216      216           
Impacted Files Coverage Δ
include/seqan3/io/sam_file/format_bam.hpp 95.00% <ø> (ø)
...clude/seqan3/io/views/detail/take_exactly_view.hpp 95.52% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@smehringer smehringer requested a review from feldroop November 7, 2022 08:22
@smehringer smehringer enabled auto-merge November 7, 2022 08:22
@eseiler eseiler requested a review from feldroop November 7, 2022 14:51
@smehringer smehringer merged commit 5ef20c7 into seqan:master Nov 7, 2022
@eseiler eseiler deleted the fix/redundant_mov branch November 7, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants