Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Make literals conditionally constexpr #3073

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Oct 20, 2022

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
seqan3 ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 7:38AM (UTC)

@seqan-actions seqan-actions added the lint [INTERNAL] signal for linting label Oct 20, 2022
@seqan-actions seqan-actions removed the lint [INTERNAL] signal for linting label Oct 20, 2022
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 98.25% // Head: 98.25% // No change to project coverage 👍

Coverage data is based on head (acb79dd) compared to base (2c697b6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3073   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         276      276           
  Lines       12344    12344           
=======================================
  Hits        12128    12128           
  Misses        216      216           
Impacted Files Coverage Δ
include/seqan3/alphabet/aminoacid/aa10li.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/aminoacid/aa10murphy.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/aminoacid/aa20.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/aminoacid/aa27.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/dna15.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/dna16sam.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/dna3bs.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/dna4.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/dna5.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/rna15.hpp 100.00% <100.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@smehringer smehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only the rebase missing. I'' check the change log then

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Oct 24, 2022
@smehringer smehringer merged commit 01ecb3b into seqan:master Oct 24, 2022
@eseiler eseiler deleted the misc/char_literal branch October 24, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add constexpr to char literals creating a vector
4 participants