Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Add more benchmarks #3065

Merged
merged 3 commits into from
Oct 20, 2022
Merged

[TEST] Add more benchmarks #3065

merged 3 commits into from
Oct 20, 2022

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Oct 18, 2022

Supersedes #1448
I'm not sure about this commit: 89872e6568d8389e9bbb993e5a0b9ec3f518bed7

@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
seqan3 ✅ Ready (Inspect) Visit Preview Oct 18, 2022 at 11:43AM (UTC)

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Oct 18, 2022
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 98.21% // Head: 98.21% // No change to project coverage 👍

Coverage data is based on head (d55bcbd) compared to base (e963e66).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3065   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         275      275           
  Lines       12244    12244           
=======================================
  Hits        12026    12026           
  Misses        218      218           
Impacted Files Coverage Δ
...e/seqan3/alphabet/container/bitpacked_sequence.hpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@smehringer
Copy link
Member

So you did not pick this commit f43e359 ? Did you check the construction time, with and without it?

@eseiler
Copy link
Member Author

eseiler commented Oct 18, 2022

So you did not pick this commit f43e359 ? Did you check the construction time, with and without it?

I didn't pick the generic read view comparison. I did pick the commit you linked.

@smehringer
Copy link
Member

So you did not pick this commit f43e359 ? Did you check the construction time, with and without it?

I didn't pick the generic read view comparison. I did pick the commit you linked.

oh sorry :D

@smehringer smehringer merged commit e723338 into seqan:master Oct 20, 2022
@eseiler eseiler deleted the test/benchmark branch October 20, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants