[INFRA] Drop gcc9 #2952

eseiler · 2022-03-25T14:12:54Z

No description provided.

vercel · 2022-03-25T14:12:58Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/3qZfjUW2qxe5pYjdwmcygai3sxTV
✅ Preview: https://seqan3-git-fork-eseiler-infra-dropgcc9-seqan.vercel.app

codecov · 2022-03-25T14:40:22Z

Codecov Report

Merging #2952 (3049495) into master (576322c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3049495 differs from pull request most recent head d081e66. Consider uploading reports for the commit d081e66 to get more accurate results

@@           Coverage Diff           @@
##           master    #2952   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files         267      267           
  Lines       11494    11494           
=======================================
  Hits        11290    11290           
  Misses        204      204

Impacted Files	Coverage Δ
...ment/aligned_sequence/aligned_sequence_concept.hpp	`100.00% <ø> (ø)`
...ment/configuration/align_config_scoring_scheme.hpp	`100.00% <ø> (ø)`
...clude/seqan3/alignment/decorator/gap_decorator.hpp	`100.00% <ø> (ø)`
...matrix/detail/advanceable_alignment_coordinate.hpp	`100.00% <ø> (ø)`
...qan3/alignment/matrix/detail/affine_cell_proxy.hpp	`100.00% <ø> (ø)`
...ignment/matrix/detail/aligned_sequence_builder.hpp	`100.00% <ø> (ø)`
...etail/alignment_matrix_column_major_range_base.hpp	`100.00% <ø> (ø)`
...qan3/alignment/matrix/detail/alignment_optimum.hpp	`100.00% <ø> (ø)`
...atrix/detail/alignment_score_matrix_one_column.hpp	`100.00% <ø> (ø)`
...etail/alignment_score_matrix_one_column_banded.hpp	`97.43% <ø> (ø)`
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576322c...d081e66. Read the comment docs.

SGSSGene

A lot of changes. My only real remark is my last annotation. Something about a shim-implementation for floating types. I didn't get that part :/

The rest looks good.

I also added a few remarks here and there, that arn't really part of the PR, but I would also never look at it again and wasn't sure if it is correct.

SGSSGene · 2022-03-30T13:53:00Z

include/seqan3/io/sequence_file/output.hpp

        f = range;
-    #endif
        return std::move(f);


Why is return f not enough?

🤷
It is definitely needed, because I tried to remove it :D
Copy elision doesn't take effect here.
I think this is some code where we have overloads for each const & && combo?

SGSSGene · 2022-03-30T13:55:12Z

include/seqan3/alignment/aligned_sequence/aligned_sequence_concept.hpp

+        {insert_gap(v, std::ranges::begin(v), 2)} -> std::same_as<std::ranges::iterator_t<t>>;
+        {erase_gap(v, std::ranges::begin(v))} -> std::same_as<std::ranges::iterator_t<t>>;
+        {erase_gap(v, std::ranges::begin(v), std::ranges::end(v))} -> std::same_as<std::ranges::iterator_t<t>>;
+        {assign_unaligned(v, unaligned)} -> std::same_as<void>;


This looks so much nicer now!

SGSSGene · 2022-03-30T13:57:28Z

include/seqan3/core/range/detail/inherited_iterator_base.hpp

@@ -230,7 +230,7 @@ class inherited_iterator_base : public std::conditional_t<std::is_pointer_v<base
    constexpr derived_t operator++(int) noexcept(noexcept(std::declval<base_t &>()++) &&
                                                 noexcept(derived_t(std::declval<base_t &>())))
    //!\cond
-        requires requires (base_t_ i) { i++; SEQAN3_RETURN_TYPE_CONSTRAINT(i++, std::same_as, base_t_); } &&
+        requires requires (base_t_ i) { i++; {i++} -> std::same_as<base_t_>; } &&


can't we leave the first i++ away?
requires requires (base_t_ i) { {i++} -> std::same_as<base_t_>; } &&

Maybe, but I wouldn't change the concept in this PR.
Theoretically, it first checks whether i++ is valid, and then whether it returns the correct type. The first i++ is probably not needed.

SGSSGene · 2022-03-30T14:03:43Z

include/seqan3/utility/container/concept.hpp

-    SEQAN3_RETURN_TYPE_CONSTRAINT(std::swap(val, val2), std::same_as, void);
+    {val.swap(val2)} -> std::same_as<void>;
+    {swap(val, val2)} -> std::same_as<void>;
+    {std::swap(val, val2)} -> std::same_as<void>;


I can't find where it says that std::swap has to be possible by the standard.

It's not really an STL concept anyway.
https://en.cppreference.com/w/cpp/algorithm/swap#Specializations

I hope these concepts are in detail? They are not really usable as one usually only needs a container to be e.g. "push-backable" but not everything else. I think this was already decided but never done

SGSSGene · 2022-03-30T14:06:44Z

README.md

@@ -66,7 +66,7 @@ Please see the [online documentation](https://docs.seqan.de/seqan/3-master-user/

 |                   | requirement                                          | version  | comment                                     |
 |-------------------|------------------------------------------------------|----------|---------------------------------------------|
-|**compiler**       | [GCC](https://gcc.gnu.org)                           | ≥ 7      | no other compiler is currently supported!   |
+|**compiler**       | [GCC](https://gcc.gnu.org)                           | ≥ 10     | no other compiler is currently supported!   |


SGSSGene · 2022-03-30T14:16:52Z

include/seqan3/std/charconv

-#include <utility> // __cpp_lib_to_chars may be defined here as currently documented
+#include <charconv>
+#include <utility> // __cpp_lib_to_chars may be defined here as currently documented.
+#include <version> // From C++20 onwards, all feature macros should be defined here.


I think the comment after the include is not required anymore.

SGSSGene · 2022-03-30T14:18:20Z

include/seqan3/std/charconv


 // =========================================================================
-// If any std implementation is present use that as basis (>= gcc8)
+// If float implementation is missing, add our own shim-implementation


I think this should still be any std?

int is provided for gcc >= 10, float for >= 11, I think.
I removed the int shim, so we only ever add float

SGSSGene

Lets go and drop gcc9!!!!

eseiler force-pushed the infra/drop_gcc9 branch 7 times, most recently from e0b6ef2 to ea6c513 Compare March 25, 2022 21:08

smehringer mentioned this pull request Mar 28, 2022

[FEATURE] Add sharg-parser submodule and replace the seqan3::argument_parser. #2954

Closed

10 tasks

eseiler force-pushed the infra/drop_gcc9 branch 3 times, most recently from 6085d78 to ef82f7b Compare March 28, 2022 18:30

eseiler added 17 commits March 29, 2022 11:53

[INFRA] Drop gcc9 from CI

9076e34

[MISC] Drop gcc9 workaround in sequence_file_output

9e6a48b

[MISC] Remove SEQAN3_WORKAROUND_ISSUE_286

6b1042c

[MISC] Remove SEQAN3_WORKAROUND_GCC_89953

030a1f2

[MISC] Drop gcc9 workaround in std/memory

7e63848

[MISC] Remove SEQAN3_RETURN_TYPE_CONSTRAINT

c57dba8

[DOC] Adapt documentation

64b90c9

[MISC] deprecate std/algorithm

bd80301

[MISC] deprecate std/concepts

ef20871

[MISC] deprecate std/iterator

7cb9e0a

[MISC] deprecate std/memory

f2734fa

[MISC] update std/ranges

322fb93

[MISC] deprecate std/type_traits

56405b1

[MISC] deprecate std/algorithm

17b6475

[MISC] deprecate std/concepts

c5ccb4b

[MISC] deprecate std/iterator

83db3ec

[MISC] deprecate std/memory

2bbdd92

eseiler added 4 commits March 29, 2022 11:53

[MISC] deprecate std/type_traits

cf0ddb8

[MISC] deprecate std/span

93a478f

[MISC] update std/charconv

eb9290b

[MISC] deprecate std/bit

f7f55cf

eseiler force-pushed the infra/drop_gcc9 branch from ef82f7b to 3049495 Compare March 29, 2022 09:53

[MISC] update core_language

d081e66

eseiler force-pushed the infra/drop_gcc9 branch from 3049495 to d081e66 Compare March 30, 2022 10:40

eseiler marked this pull request as ready for review March 30, 2022 10:41

SGSSGene requested changes Mar 30, 2022

View reviewed changes

eseiler requested a review from SGSSGene March 30, 2022 14:50

SGSSGene approved these changes Mar 30, 2022

View reviewed changes

eseiler requested a review from smehringer March 31, 2022 07:56

smehringer approved these changes Mar 31, 2022

View reviewed changes

smehringer merged commit dc1ef8c into seqan:master Mar 31, 2022

eseiler deleted the infra/drop_gcc9 branch March 31, 2022 14:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[INFRA] Drop gcc9 #2952

[INFRA] Drop gcc9 #2952

eseiler commented Mar 25, 2022

vercel bot commented Mar 25, 2022 •

edited

Loading

codecov bot commented Mar 25, 2022 •

edited

Loading

SGSSGene left a comment

SGSSGene Mar 30, 2022

eseiler Mar 30, 2022

SGSSGene Mar 30, 2022

SGSSGene Mar 30, 2022

eseiler Mar 30, 2022

SGSSGene Mar 30, 2022

eseiler Mar 30, 2022

smehringer Mar 31, 2022

SGSSGene Mar 30, 2022

SGSSGene Mar 30, 2022

SGSSGene Mar 30, 2022

eseiler Mar 30, 2022

SGSSGene left a comment

[INFRA] Drop gcc9 #2952

[INFRA] Drop gcc9 #2952

Conversation

eseiler commented Mar 25, 2022

vercel bot commented Mar 25, 2022 • edited Loading

codecov bot commented Mar 25, 2022 • edited Loading

Codecov Report

SGSSGene left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SGSSGene left a comment

Choose a reason for hiding this comment

vercel bot commented Mar 25, 2022 •

edited

Loading

codecov bot commented Mar 25, 2022 •

edited

Loading