Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] gcc-10.3 supports SEQAN3_WORKAROUND_GCC_99318 now #2626

Merged
merged 1 commit into from
May 11, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented May 10, 2021

Part of release checklist (#2334)

Go through workarounds and re-evaluate them. This workaround is apparently fixed since gcc-10.3 so let's see :)

@marehr marehr requested review from a team and MitraDarja and removed request for a team May 10, 2021 23:29
@vercel
Copy link

vercel bot commented May 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/HDvX3BjDkLsBbBaw6EYSgqeCtV2n
✅ Preview: https://seqan3-git-fork-marehr-removeworkarounds3-seqan.vercel.app

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #2626 (ff61cb6) into master (77c5e8a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2626   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         273      273           
  Lines       10795    10795           
=======================================
  Hits        10609    10609           
  Misses        186      186           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c5e8a...ff61cb6. Read the comment docs.

@MitraDarja MitraDarja requested a review from eseiler May 11, 2021 07:45
@eseiler eseiler merged commit adc0324 into seqan:master May 11, 2021
@marehr marehr deleted the remove_workarounds3 branch May 11, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants