Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] API stability #2559

Merged
merged 3 commits into from
Apr 26, 2021
Merged

[FIX] API stability #2559

merged 3 commits into from
Apr 26, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented Apr 25, 2021

fixes #2558

@marehr marehr requested review from a team and SGSSGene and removed request for a team April 25, 2021 16:54
@vercel
Copy link

vercel bot commented Apr 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/8r5MzueMu2yFsqZTxtgQJzneEeXL
✅ Preview: https://seqan3-git-fork-marehr-fixapistability-seqan.vercel.app

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #2559 (f75493a) into master (e0ea37a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2559   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         269      269           
  Lines       10541    10545    +4     
=======================================
+ Hits        10355    10359    +4     
  Misses        186      186           
Impacted Files Coverage Δ
include/seqan3/alphabet/nucleotide/dna16sam.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/quality/phred68solexa.hpp 100.00% <ø> (ø)
...n3/search/dream_index/interleaved_bloom_filter.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ea37a...f75493a. Read the comment docs.

@eseiler eseiler changed the title Fix api stability [FIX] API stability Apr 26, 2021
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SGSSGene SGSSGene requested review from a team and eseiler and removed request for a team April 26, 2021 12:41
@eseiler eseiler merged commit 5cd019b into seqan:master Apr 26, 2021
@marehr marehr deleted the fix_api_stability branch April 26, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CRON] API Stability Failure
3 participants