[MISC] deprecate seqan3::views::to_upper #2538
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/CS4fNm9nh9iUHHXmSUWBdxgG3yN3 |
Codecov Report
@@ Coverage Diff @@
## master #2538 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 269 269
Lines 10540 10540
=======================================
Hits 10354 10354
Misses 186 186
Continue to review full report at Codecov.
|
|
|
||
| } // namespace seqan3::views | ||
| SEQAN3_DEPRECATED_HEADER( | ||
| "This header is deprecated and will be removed in SeqAn-3.1.0.") |
There was a problem hiding this comment.
memo to myself: this is an interesting idea :)
| return seqan3::to_upper(in); | ||
| })}; | ||
| #ifdef SEQAN3_DEPRECATED_310 | ||
| SEQAN3_DEPRECATED_310 inline constexpr auto drop = detail::drop_fn{}; |
There was a problem hiding this comment.
this should be the to_upper definition as before :)
MitraDarja
requested review from
a team and
Irallia
and removed request for
a team
| "The value type of seqan3::views::to_upper must model the seqan3::builtin_character."); | ||
| "The value type of seqan3::views::to_upper must model the seqan3::builtin_character."); |
There was a problem hiding this comment.
This looks like a miscorrection.
Irallia
requested review from
a team,
eseiler and
marehr
and removed request for
a team and
eseiler
Resolves seqan/product_backlog#334