[MISC] Alphabet: rename phred68legacy to phred68solexa #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/G14mU9rJ497WYDuSo5FM7mevMjRw |
Codecov Report
@@ Coverage Diff @@
## master #2522 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 269 269
Lines 10521 10521
=======================================
Hits 10334 10334
Misses 187 187
Continue to review full report at Codecov.
|
|
Snippets failed |
marehr
requested review from
a team and
MitraDarja
and removed request for
a team
Irallia
force-pushed
the
misc/alphabet/rename_phred68legacy_to_phred68solexa
branch
2 times, most recently
from
0d7da40 to
ddcc169
Compare
MitraDarja
approved these changes
Apr 19, 2021
MitraDarja
requested review from
a team and
marehr
and removed request for
a team
eseiler
reviewed
Apr 19, 2021
Irallia
force-pushed
the
misc/alphabet/rename_phred68legacy_to_phred68solexa
branch
from
ddcc169 to
eb9196b
Compare
eseiler
reviewed
Apr 19, 2021
CHANGELOG.md
Outdated
| @@ -32,6 +32,8 @@ If possible, provide tooling that performs the changes, e.g. a shell-script. | |||
|
|
|||
| * Added `seqan3::phred94`, a quality type that represents the full Phred Score range (Sanger format) and is used for | |||
| PacBio Phred scores of HiFi reads ([\#2290](https://github.com/seqan/seqan3/pull/2290)). | |||
| * Deprecated `seqan3::phred68legacy`. Use `seqan3::phred68solexa` instead. | |||
| ([\#...](https://github.com/seqan/seqan3/pull/2522)). | |||
There was a problem hiding this comment.
Suggested change
| ([\#...](https://github.com/seqan/seqan3/pull/2522)). | |
| ([\#2522](https://github.com/seqan/seqan3/pull/2522)). |
There was a problem hiding this comment.
I would rather write renamed X to Y
Deprecation is usually more for stuff that does not exist anymore
eseiler
reviewed
Apr 19, 2021
eseiler
reviewed
Apr 19, 2021
eseiler
requested changes
Apr 19, 2021
CHANGELOG.md
Outdated
| @@ -32,6 +32,8 @@ If possible, provide tooling that performs the changes, e.g. a shell-script. | |||
|
|
|||
| * Added `seqan3::phred94`, a quality type that represents the full Phred Score range (Sanger format) and is used for | |||
| PacBio Phred scores of HiFi reads ([\#2290](https://github.com/seqan/seqan3/pull/2290)). | |||
| * Deprecated `seqan3::phred68legacy`. Use `seqan3::phred68solexa` instead. | |||
| ([\#...](https://github.com/seqan/seqan3/pull/2522)). | |||
There was a problem hiding this comment.
I would rather write renamed X to Y
Deprecation is usually more for stuff that does not exist anymore
Signed-off-by: Lydia Buntrock <[email protected]>
Signed-off-by: Lydia Buntrock <[email protected]>
Irallia
force-pushed
the
misc/alphabet/rename_phred68legacy_to_phred68solexa
branch
from
eb9196b to
cf52cf8
Compare
Signed-off-by: Lydia Buntrock <[email protected]>
Irallia
force-pushed
the
misc/alphabet/rename_phred68legacy_to_phred68solexa
branch
from
cf52cf8 to
975c06e
Compare
eseiler
reviewed
Apr 20, 2021
eseiler
reviewed
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: seqan/product_backlog#315