Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] use new CPO-way to define seqan3::assign_phred_to #2476

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented Mar 23, 2021

@vercel
Copy link

vercel bot commented Mar 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/BEXwYcapV1qqbhPA8u6DJpvgVD6u
✅ Preview: https://seqan3-git-fork-marehr-newcpo11-seqan.vercel.app

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #2476 (33d83c0) into master (e616011) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2476   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         267      268    +1     
  Lines       11063    11063           
=======================================
  Hits        10875    10875           
  Misses        188      188           
Impacted Files Coverage Δ
include/seqan3/alphabet/quality/concept.hpp 100.00% <100.00%> (ø)
include/seqan3/core/detail/customisation_point.hpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e616011...33d83c0. Read the comment docs.

@marehr marehr requested review from a team and simonsasse and removed request for a team March 24, 2021 16:15
Copy link
Member

@simonsasse simonsasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@marehr marehr requested a review from eseiler March 29, 2021 08:16
@eseiler eseiler merged commit c40960b into seqan:master Mar 29, 2021
@marehr marehr deleted the new_cpo11 branch April 14, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants