Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] seqan3::range_compatible deprecation should be concept-like #2461

Merged
merged 2 commits into from
Mar 23, 2021
Merged

[MISC] seqan3::range_compatible deprecation should be concept-like #2461

merged 2 commits into from
Mar 23, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented Mar 22, 2021

This PR makes the old seqan3::range_compatible concept (change made in aa1ed00) work again with false inputs (SFINAE-friendly).

Before, seqan3::range_compatible<int, int> gave a hard compiler
error.

This makes the upgrade-path from 3.0.2 to 3.0.3 easier.

@marehr
[MISC] seqan3::range_compatible deprecation should be concept-like
ea6bc32 
This PR makes the old seqan3::range_compatible concept (change made in
aa1ed00) work again with false inputs
(SFINAE-friendly).

Before, `seqan3::range_compatible<int, int>` gave a hard compiler
error.

This makes the upgrade-path from 3.0.2 to 3.0.3 easier.
@marehr marehr requested review from a team and SGSSGene and removed request for a team March 22, 2021 01:28
@vercel
Copy link

vercel bot commented Mar 22, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/DxT1WZ3qi2K5A4DJww7CZMPeVhqg
✅ Preview: https://seqan3-git-fork-marehr-api-stable03-seqan.vercel.app

@codecov
Copy link

codecov bot commented Mar 22, 2021 •
edited
Loading

Codecov Report

Merging #2461 (2ad7b3e) into master (de4db1f) will not change coverage.
The diff coverage is n/a.

❗ Current head 2ad7b3e differs from pull request most recent head e638470. Consider uploading reports for the commit e638470 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2461   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         267      267           
  Lines       11063    11063           
=======================================
  Hits        10875    10875           
  Misses        188      188

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de4db1f...e638470. Read the comment docs.

SGSSGene
SGSSGene approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SGSSGene SGSSGene requested review from a team and eseiler and removed request for a team March 23, 2021 17:27
eseiler
eseiler approved these changes Mar 23, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@eseiler eseiler enabled auto-merge (squash) March 23, 2021 17:42
@eseiler eseiler merged commit e616011 into seqan:master Mar 23, 2021
@marehr marehr deleted the api-stable03 branch March 23, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseiler eseiler eseiler approved these changes

@SGSSGene SGSSGene SGSSGene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marehr @SGSSGene @eseiler