Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alignment configuration] Free end gap configuration - documentation and removal of aligned_ends #2119

Merged

Conversation

smehringer
Copy link
Member

Final PR of #2032
Closes #2032

Resolves seqan/product_backlog/issues/96

@smehringer smehringer requested a review from marehr September 16, 2020 16:00
@marehr
Copy link
Member

marehr commented Sep 16, 2020

Can you rebase and make it compile?

Copy link
Member

@marehr marehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Can you make it compile?)

@smehringer
Copy link
Member Author

Oh, when I made the PR it at least was mergeable.
Sure

@smehringer smehringer changed the title [Alignment configuration] [Alignment configuration] Free end gap configuration - documentation and removal of aligned_ends Sep 17, 2020
@smehringer smehringer force-pushed the alignment_configuration_free_end_gaps_1 branch 7 times, most recently from 2b325d7 to 79f4e41 Compare September 18, 2020 08:21
@smehringer smehringer requested a review from marehr September 18, 2020 08:21
@smehringer
Copy link
Member Author

@marehr everything should be fine now

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #2119 into release-3.0.2 will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-3.0.2    #2119      +/-   ##
=================================================
- Coverage          97.83%   97.82%   -0.01%     
=================================================
  Files                264      263       -1     
  Lines               9958     9945      -13     
=================================================
- Hits                9742     9729      -13     
  Misses               216      216              
Impacted Files Coverage Δ
...e/seqan3/alignment/pairwise/detail/type_traits.hpp 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a51106...de30cb9. Read the comment docs.

@smehringer smehringer force-pushed the alignment_configuration_free_end_gaps_1 branch from 79f4e41 to e00217b Compare September 18, 2020 10:18
@smehringer
Copy link
Member Author

Ok now even the snippets should be fine.

Copy link
Member

@marehr marehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small documentation stuff; thank you! :)

doc/tutorial/pairwise_alignment/configurations.cpp Outdated Show resolved Hide resolved
doc/tutorial/pairwise_alignment/index.md Outdated Show resolved Hide resolved
doc/tutorial/pairwise_alignment/index.md Outdated Show resolved Hide resolved
@smehringer smehringer requested a review from marehr September 21, 2020 11:26
Copy link
Member

@marehr marehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty :)

@smehringer smehringer force-pushed the alignment_configuration_free_end_gaps_1 branch from 2f0a1ec to de30cb9 Compare September 22, 2020 12:01
@smehringer smehringer requested a review from rrahn September 22, 2020 12:01
@rrahn
Copy link
Contributor

rrahn commented Sep 22, 2020

can you rebase real quick? Or can I squash merge?

@rrahn rrahn merged commit 3051830 into seqan:release-3.0.2 Sep 22, 2020
@smehringer smehringer deleted the alignment_configuration_free_end_gaps_1 branch September 24, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants