-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment configuration free end gaps #1938
Alignment configuration free end gaps #1938
Conversation
400f90f
to
74f2fc8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1938 +/- ##
=======================================
Coverage 97.88% 97.89%
=======================================
Files 261 262 +1
Lines 9831 9865 +34
=======================================
+ Hits 9623 9657 +34
Misses 208 208
Continue to review full report at Codecov.
|
74f2fc8
to
eb9e225
Compare
eb9e225
to
c1c7bcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably does affect users?
If so, add a changelog entry (except it was added after the last release).
BTW, we do not have [NOP] labels for commits :D
I will add one with the last PR for free end gaps. since right now the change would say |
Do you want to rebase or should I squash? |
1a2171c
to
d58bebc
Compare
Part of seqan/product_backlog#96
I split the tasks such that the PR doesn't become too large.
Fixes tasks 1 & 2: