[FIX] Iterator Tag in kmer_hash #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitraDarja
requested review from
a team and
Irallia
and removed request for
a team
Merged
Codecov Report
@@ Coverage Diff @@
## master #1710 +/- ##
==========================================
+ Coverage 97.65% 97.68% +0.02%
==========================================
Files 237 237
Lines 9048 9057 +9
==========================================
+ Hits 8836 8847 +11
+ Misses 212 210 -2
Continue to review full report at Codecov.
|
smehringer
reviewed
Apr 2, 2020
|
@smehringer What other tests do you want to add? There are already concept tests. |
rrahn
requested changes
Apr 3, 2020
| @@ -224,7 +224,7 @@ class kmer_hash_view<urng_t>::shape_iterator | |||
| //!\brief Reference to `value_type`. | |||
| using reference = value_type; | |||
| //!\brief Tag this class as input iterator. | |||
| using iterator_category = std::input_iterator_tag; | |||
| using iterator_category = iterator_tag_t<it_t>; | |||
There was a problem hiding this comment.
Suggested change
| using iterator_category = iterator_tag_t<it_t>; | |
| using iterator_category = typename std::iterator_traits<it_t>::iterator_category; |
There was a problem hiding this comment.
I think seqan3::iterator_tag_t was more correct.
See #853
IIRC iterators may not provide the category, at least we encountered it sometimes...
Or we somewhere down the line expect that it is there...
MitraDarja
force-pushed
the
fix/kmer_hash_it
branch
from
7a85299 to
d3c2438
Compare
rrahn
requested changes
Apr 6, 2020
MitraDarja
force-pushed
the
fix/kmer_hash_it
branch
from
d3c2438 to
8c40faa
Compare
rrahn
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the minimiser view (#1654) I had problems preserving the forward_range properties, changing the tag in the kmer hash from input range to iterator_tag solved this problem.