-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes the exception names of the argument parser consistent #1467
Conversation
fe5b951
to
70bb020
Compare
70bb020
to
bf64382
Compare
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
==========================================
+ Coverage 97.58% 97.62% +0.04%
==========================================
Files 235 235
Lines 8844 8855 +11
==========================================
+ Hits 8630 8645 +15
+ Misses 214 210 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some typos. :)
sorry I did not see that you approved already. You can or cannot check the differences and approve again. In general if you find typos, you can request changes as they are just as valid as code changing requests. |
ec5002a
to
9a15ab1
Compare
9a15ab1
to
9cc42bc
Compare
Sorry, I had to rebase and add a different commit for the renaming in the documentation to keep the history clean. Doing that later would have been too compilcated. |
9cc42bc
to
8f3b0ca
Compare
8f3b0ca
to
9cbd5d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few things left
85af7ba
to
b89e594
Compare
b89e594
to
d029b64
Compare
Have you verified the code coverage issue? |
It has nothing to do with me. I'll rebase to current master to see if this fixes it. |
d029b64
to
34f548f
Compare
@rrahn Code coverage only fails because of the filesystem errors that in the file validators were renamed but are not tested. So I think this can be merged. |
34f548f
to
a5ca7d4
Compare
@rrahn I updated the Changelog entry to link this PR. |
Resolves #481
I changed the names according to our resolution in the strategy meeting (card)
Additionally, the first commit get's rid of the internal exception in the function retrive_value. The success is indicated by a return value instead and the exception is thrown outside. This also made the exceptions std::type_conversion-error and std::overflow_errow obsolete which lowers the number of exceptions in general.