Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] accept any case in find_package(sEqAn3) #1427

Merged
merged 4 commits into from
Jan 9, 2020

Conversation

marehr
Copy link
Member

@marehr marehr commented Dec 15, 2019

This PR improves two things:

  • Accept any case in find_package(seqAN3)
  • We now use the standard way (find_package_handle_standard_args) to tell find_package if the package was found or not (code reduction).

@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #1427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1427   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         234      234           
  Lines        8785     8785           
=======================================
  Hits         8574     8574           
  Misses        211      211

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87bf74e...4fc392b. Read the comment docs.

@marehr marehr requested a review from eseiler December 17, 2019 13:28
CHANGELOG.md Outdated Show resolved Hide resolved
build_system/seqan3-config.cmake Outdated Show resolved Hide resolved
@marehr marehr requested a review from eseiler December 18, 2019 14:21
@marehr marehr requested a review from rrahn December 19, 2019 13:18
Copy link
Contributor

@rrahn rrahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Some minor 💅 stuff

CHANGELOG.md Outdated
@@ -21,6 +21,10 @@ If possible, provide tooling that performs the changes, e.g. a shell-script.

## New features

### CMake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### CMake
### Build system

build_system/seqan3-config.cmake Show resolved Hide resolved
@marehr marehr requested a review from rrahn January 4, 2020 20:22
@rrahn
Copy link
Contributor

rrahn commented Jan 8, 2020

@marehr this can be now squashed and then merged. Many thanks.

@marehr marehr force-pushed the cmake_find_package_fixes branch from ed96c99 to 4fc392b Compare January 8, 2020 18:41
@marehr marehr requested a review from rrahn January 8, 2020 18:41
@marehr
Copy link
Member Author

marehr commented Jan 8, 2020

@rrahn done

@rrahn rrahn merged commit 5a42b14 into seqan:master Jan 9, 2020
@marehr marehr deleted the cmake_find_package_fixes branch January 9, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants