[MISC] deprecate seqan3::views::move

CHANGELOG.md

@@ -210,6 +210,9 @@ regression test suite and patches at https://github.com/seqan/seqan3/tree/master
   ([\#2524](https://github.com/seqan/seqan3/pull/2524)).
 * Deprecated `seqan3::views::drop`, use `std::views::drop` or `seqan3::views::type_reduce | std::views::drop`.
   ([\#2540](https://github.com/seqan/seqan3/pull/2540))
+* Deprecated `seqan3::views::move`, use the `std::ranges::move` algorithm, `std::[cpp20::]move_iterator` or an explicit
+  for loop where you move the value.
+  ([\#2563](https://github.com/seqan/seqan3/pull/2563))
 * We deprecated `seqan3::views::to_upper` and it will be removed in 3.1.0, use
   `std::views::transform([](auto && chr){return std::toupper(chr)})`.
   ([\#2540](https://github.com/seqan/seqan3/pull/2538))

include/seqan3/range/views/move.hpp

@@ -66,12 +66,16 @@ namespace seqan3::views
  *
  * A more useful example can be found in \link sequence_file_section_fun_with_ranges the tutorial \endlink.
  * \hideinitializer
+ * \deprecated Use the std::ranges::move algorithm, std::[cpp20::]move_iterator or an explicit for loop where you move
+ *             the value.
  */
-inline auto const move = std::views::transform(detail::multi_invocable
+#ifdef SEQAN3_DEPRECATED_310
+SEQAN3_DEPRECATED_310 inline auto const move = std::views::transform(detail::multi_invocable
 {
     [] (auto && arg) -> std::remove_cvref_t<decltype(arg)> { return std::move(arg); },
     [] (auto  & arg) -> decltype(auto)                { return std::move(arg); }
 });
+#endif // SEQAN3_DEPRECATED_310
 //!\}
 
 } // namespace seqan3::views

test/snippet/range/views/move.cpp

@@ -1,3 +1,8 @@
+#include <seqan3/core/platform.hpp>
+
+#ifdef SEQAN3_DEPRECATED_310
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 #include <string>
 
 #include <seqan3/range/views/move.hpp>
@@ -18,3 +23,5 @@ int main()
     std::ranges::copy(vec_in | seqan3::views::move, // moves strings from in to out
                       vec_out1.begin());
 }
+#pragma GCC diagnostic pop
+#endif // SEQAN3_DEPRECATED_310

test/snippet/utility/views/drop.cpp

@@ -1,3 +1,5 @@
+#include <seqan3/core/platform.hpp>
+
 #ifdef SEQAN3_DEPRECATED_310
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wdeprecated-declarations"

test/unit/range/views/drop_test.cpp

@@ -20,7 +20,9 @@
 
 #include <seqan3/range/concept.hpp>
 #include <seqan3/range/container/concept.hpp>
+#ifdef SEQAN3_DEPRECATED_310
 #include <seqan3/range/views/drop.hpp>
+#endif // SEQAN3_DEPRECATED_310
 #include <seqan3/range/views/single_pass_input.hpp>
 #include <seqan3/test/expect_range_eq.hpp>
 #include <seqan3/test/expect_same_type.hpp>

test/unit/range/views/move_test.cpp

@@ -15,9 +15,15 @@
 #include <seqan3/alphabet/views/complement.hpp>
 #include <seqan3/core/detail/debug_stream_alphabet.hpp>
 #include <seqan3/range/concept.hpp>
+#ifdef SEQAN3_DEPRECATED_310
 #include <seqan3/range/views/move.hpp>
+#endif // SEQAN3_DEPRECATED_310
 #include <seqan3/test/expect_range_eq.hpp>
 
+#ifdef SEQAN3_DEPRECATED_310
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
 using seqan3::operator""_dna5;
 
 TEST(view_move, basic)
@@ -69,3 +75,6 @@ TEST(view_move, concepts)
 
     EXPECT_TRUE((std::is_same_v<decltype(v2[0]), seqan3::dna5>)); // don't add const-ness to values
 }
+
+#pragma GCC diagnostic pop
+#endif // SEQAN3_DEPRECATED_310