Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LedCarveTask might miss a lot of items #1452

Closed
lfcnassif opened this issue Dec 19, 2022 · 1 comment
Closed

LedCarveTask might miss a lot of items #1452

lfcnassif opened this issue Dec 19, 2022 · 1 comment
Assignees
@lfcnassif
Labels
bug

Comments

@lfcnassif
Copy link
Member

lfcnassif commented Dec 19, 2022 •
edited
Loading

Taking a quick look at LedCarveTask trying to find possible causes of divergences of results to default CarverTask reported by an user, I found some InputStream.read(byte[]) calls are not being retried to full fill the buffer, that call may return less bytes than requested before end of stream depending on implementation (and we have some InputStream implementations doing this, it is OK according to java API).
@lfcnassif lfcnassif added the bug label Dec 19, 2022
@lfcnassif lfcnassif self-assigned this Dec 19, 2022
lfcnassif added a commit that referenced this issue Dec 19, 2022
@lfcnassif
'#1452: use new java 11 readNBytes method to guarantee N bytes are read
811d5a7
lfcnassif added a commit that referenced this issue Dec 19, 2022
@lfcnassif
'#1452: also fixes IOUtil readByteArray and readIntArray methods
1488fdf
@lfcnassif
Copy link
Member Author

@tc-wleite the fix is very simple so I pushed it directly to master.

@lfcnassif lfcnassif changed the title LedCarveTask may miss a lot of items LedCarveTask might miss a lot of items Dec 20, 2022
lfcnassif added a commit that referenced this issue Dec 20, 2022
@lfcnassif
'#1452: use new java 11 readNBytes method to guarantee N bytes are read
69263b5
lfcnassif added a commit that referenced this issue Dec 20, 2022
@lfcnassif
'#1452: also fixes IOUtil readByteArray and readIntArray methods
3246489
@lfcnassif lfcnassif mentioned this issue Dec 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lfcnassif lfcnassif

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lfcnassif