Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI glitch in similar image search panel #1365

Closed
wladimirleite opened this issue Oct 12, 2022 · 7 comments
Closed

Minor UI glitch in similar image search panel #1365

wladimirleite opened this issue Oct 12, 2022 · 7 comments
Assignees
Labels

Comments

@wladimirleite
Copy link
Member

I noticed a while ago two really minor glitches in the analysis tool user interface.
They depend on the screen resolution and most users won't even notice them.
Anyway, I would like to fix them.

@wladimirleite wladimirleite self-assigned this Oct 12, 2022
@wladimirleite
Copy link
Member Author

When a search for similar images is made, the UI presents a small panel with the reference image thumbnail.
The red borders look odd and there is a small part of the image drawn outside the borders.

similarity-odd-borders

@wladimirleite
Copy link
Member Author

wladimirleite commented Oct 12, 2022

In hexadecimal viewer, depending on the screen resolution and the font size used, the vertical line (between the raw hexadecimal values and the corresponding characters) is drawn in the wrong place.
hvp

And for some font sizes, characters are drawn out of place, sometimes overlapping other characters.
hvp2

@wladimirleite wladimirleite changed the title Minor UI glitches in similar image search panel and hexadecimal viewer Minor UI glitch in similar image search panel Oct 12, 2022
@wladimirleite
Copy link
Member Author

Unfortunately, the glitches in the hexadecimal viewer are inside library code.
We are using version 0.1.3 of the library, and it seems that the latest stable version is 0.2.1 (or 0.2.0 or 0.2.2).
However, it is not simple to update, as there were major refactors, and many classes and methods were renamed, chagend or even removed.

Testing with two other configurations (different resolution, JRE and SO version), I noticed that font size = 13 produced the best results (less noticable glitches).
So for now, I will only change the default font size from 14 to 13.

@lfcnassif
Copy link
Member

When a search for similar images is made, the UI presents a small panel with the reference image thumbnail. The red borders look odd and there is a small part of the image drawn outside the borders.

similarity-odd-borders

Hi @tc-wleite, I didn't manage to reproduce this. Are you using a 4K resolution monitor? Or changed some configuration?

@lfcnassif
Copy link
Member

They depend on the screen resolution

Just read this, I'll try with some resolutions.

@wladimirleite
Copy link
Member Author

Hi @tc-wleite, I didn't manage to reproduce this. Are you using a 4K resolution monitor? Or changed some configuration?

Just read this, I'll try with some resolutions.

Yes, it depends on the used resolution (screen dimensions and pixel density).
In my laptop I can't notice the same effect.
I didn't change anything recently, but I guess the behavior is present (in my PC) since we starting using Java 11. There is "some" level of scaling (fonts and other things are a bit larger than in Java 8) in my resolution.

I would like to point out that the new border painting is more "robust", and it should work better in any resolution.

@lfcnassif
Copy link
Member

Fixed by #1366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants