Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sprite for HK and KR #97

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update sprite for HK and KR #97

wants to merge 2 commits into from

Conversation

tommi-lew
Copy link
Contributor

@tommi-lew tommi-lew commented Aug 24, 2019 •
edited
Loading

  • Additional payment logos for HK and KR
  • KR flag

This is a dependency for #94 which requires the KR flag on this new sprite.
Supersedes #87 .

@tommi-lew
Update sprite for HK and KR
ebd9e61 
- Additional payment logos for HK and KR
- KR flag
@tommi-lew
Copy link
Contributor Author

@yuralala8 As a FYI.
@tachyons For HK new payment types.
@zamakkat and @ycewe as they are likely to have most context on style guide.

@tommi-lew
Copy link
Contributor Author

Dankew

@tachyons
Add sprite dimension to css

@tommi-lew
Copy link
Contributor Author

Note to self: This is no longer relevant for HK as a seperate PR is merged. There will be conflicts with the sprite file and it has to be resolved manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tachyons tachyons Awaiting requested review from tachyons

@zamakkat zamakkat Awaiting requested review from zamakkat

@ycewe ycewe Awaiting requested review from ycewe

@yuralala8 yuralala8 Awaiting requested review from yuralala8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommi-lew @tachyons