Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python/fmt/cif): pass internal reference to subobject and support inconsistent CIF files #447

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

jnooree
Copy link
Member

@jnooree jnooree commented Jan 6, 2025

Checklist

If the change is related to the source code, tests, or build environments, please also check the following:

  • Does ./scripts/run_clang_tools.sh pass without any warnings?
  • Have you built the project locally without any warnings and errors?
  • Do all tests (if new tests are added, including the new ones) pass?

If you added new feature(s), then also check the following:

  • Did you also add corresponding tests?

Linked Issues

Link the tracking issue(s) of this PR, with the auto-close keywords here:


@jnooree jnooree added bug Something isn't working feature New features or improvements engineering Performance, refactoring, etc. python Related to python interface labels Jan 6, 2025
@jnooree jnooree enabled auto-merge January 6, 2025 12:57
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.15%. Comparing base (81f797b) to head (b7e504e).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
python/src/nuri/fmt/cif.cpp 84.37% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   91.18%   91.15%   -0.03%     
==========================================
  Files          58       58              
  Lines       13477    13484       +7     
==========================================
+ Hits        12289    12292       +3     
- Misses       1188     1192       +4     
Files with missing lines Coverage Δ
python/include/nuri/python/utils.h 97.93% <100.00%> (+0.01%) ⬆️
python/src/nuri/fmt/cif.cpp 92.10% <84.37%> (-2.42%) ⬇️

@jnooree jnooree merged commit a43aaed into main Jan 6, 2025
14 of 16 checks passed
@jnooree jnooree deleted the python/fmt/fix-cif branch January 6, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working engineering Performance, refactoring, etc. feature New features or improvements python Related to python interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant