Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python/fmt/cif): add utility function to convert DDL2 CIF to dict #446

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

jnooree
Copy link
Member

@jnooree jnooree commented Jan 6, 2025

Checklist

If the change is related to the source code, tests, or build environments, please also check the following:

  • Does ./scripts/run_clang_tools.sh pass without any warnings?
  • Have you built the project locally without any warnings and errors?
  • Do all tests (if new tests are added, including the new ones) pass?

If you added new feature(s), then also check the following:

  • Did you also add corresponding tests?

Linked Issues

Link the tracking issue(s) of this PR, with the auto-close keywords here:


@jnooree jnooree added the python Related to python interface label Jan 6, 2025
@jnooree jnooree enabled auto-merge January 6, 2025 09:22
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (41b0a4d) to head (29ae430).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   91.15%   91.18%   +0.02%     
==========================================
  Files          58       58              
  Lines       13434    13477      +43     
==========================================
+ Hits        12246    12289      +43     
  Misses       1188     1188              
Files with missing lines Coverage Δ
python/src/nuri/fmt/cif.cpp 94.52% <100.00%> (+2.13%) ⬆️

... and 1 file with indirect coverage changes

@jnooree jnooree merged commit 81f797b into main Jan 6, 2025
16 checks passed
@jnooree jnooree deleted the python/fmt/cif-perf branch January 6, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to python interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant