Use workaround for windows x509.SystemCertPool() #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2020 14:24
Signed-off-by: Nikki Attea <[email protected]>
Signed-off-by: Nikki Attea <[email protected]>
palourde
approved these changes
Sep 22, 2020
wscheele
added a commit
to wscheele/jaeger
that referenced
this pull request
Oct 11, 2020
Resolves jaegertracing#2550 Borrows workaround from Sensu: sensu/sensu-go#4018 Signed-off-by: Wouter Scheele <[email protected]>
wscheele
added a commit
to wscheele/jaeger
that referenced
this pull request
Oct 11, 2020
Resolves jaegertracing#2550 Borrows workaround from Sensu: sensu/sensu-go#4018 Signed-off-by: Wouter Scheele <[email protected]> Signed-off-by: Wouter Scheele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikki Attea [email protected]
What is this change?
Implements the workaround detailed in golang/go#16736 (comment) to fix asset trusted ca file on windows agents.
Why is this change necessary?
Closes #4016
Does your change need a Changelog entry?
No, not a regression, fixes bug introduced in unreleased #3975
The trusted CA file is now used for agent-side asset retrieval.Do you need clarification on anything?
Nah.
Were there any complications while making this change?
Have you reviewed and updated the documentation for this change? Is new documentation required?
We good.
How did you verify this change?
I deployed a whole windows golang env to test this 🙃 Verifying in a build with crucible now.
Is this change a patch?
Yes, but targeting master for the next release.