Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated etcd to 3.3.2 #1193

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Updated etcd to 3.3.2 #1193

merged 1 commit into from
Mar 21, 2018

Conversation

mercul3s
Copy link
Contributor

What is this change?

Updates etcd to 3.3.2 so we can set autocompaction revision to an actual int instead of a time-based value.

Why is this change necessary?

Closes #1069

Does your change need a Changelog entry?

Added a note under Changed section.

Do you need clarification on anything?

Nope!

Were there any complications while making this change?

Nope!

Copy link
Contributor

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jamesdphillips any idea why the Gopkg.lock file tends to stutter like this?

@amdprophet
Copy link
Member

@echlebek it's likely due to differing versions of dep on each of our systems. I haven't found a great way to ensure we all have the same version of system-level go tools.

@jamesdphillips
Copy link
Contributor

If you're on a mac try running brew upgrade dep to update to the latest stable version. Also, double check that you haven't installed it through go get.

$ dep version
dep:
 version     : v0.4.1
 build date  : 2018-01-27
 git hash    : 37d9ea0
 go version  : go1.9.3
 go compiler : gc
 platform    : darwin/amd64

I haven't found a great way to ensure we all have the same version of system-level go tools.

As far as I'm concerned this is this is something dep should be responsible for checking...

@echlebek
Copy link
Contributor

I'm not on a mac but I think Mercedes is. I probably won't be installing dep with brew ;)

@mercul3s
Copy link
Contributor Author

Just updated dep - I was running a really old development version! Let me see if that has any effect on the lockfile.

@echlebek
Copy link
Contributor

Turns out I was running a development version too. I followed the installation instructions and upgraded to 0.4.1.

Autocompaction revision mode can now be set to an integer instead of a
time-based value.

Signed-off-by: Mercedes Coyle <[email protected]>
@mercul3s mercul3s force-pushed the update-etcd-3.3.2 branch from a566b87 to 6ea4855 Compare March 21, 2018 00:21
@mercul3s
Copy link
Contributor Author

Updated dep put the lockfile back to the way it was 👍

@mercul3s mercul3s merged commit 6303e65 into master Mar 21, 2018
@mercul3s mercul3s deleted the update-etcd-3.3.2 branch March 21, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants