Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log level increment commands #2406

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Add log level increment commands #2406

merged 1 commit into from
Apr 28, 2020

Conversation

hillaryfraley
Copy link
Contributor

Description

Adds commands to increment log level in troubleshooting section (https://docs.sensu.io/sensu-go/latest/guides/troubleshooting/#log-levels)

Motivation and Context

Closes #2394

Review Instructions

@echlebek we have not documented the trace log level -- should it be added to the table here: https://docs.sensu.io/sensu-go/latest/guides/troubleshooting/#log-levels

@hillaryfraley hillaryfraley added ready for review PR is ready to review update Add to or refresh existing info labels Apr 28, 2020
@hillaryfraley hillaryfraley added this to the 5.20.0 milestone Apr 28, 2020
@hillaryfraley hillaryfraley requested a review from echlebek April 28, 2020 18:52
@hillaryfraley hillaryfraley self-assigned this Apr 28, 2020
@cwjohnston cwjohnston temporarily deployed to sensu-docs-increment-lo-8zgbvh April 28, 2020 18:52 Inactive
echlebek
echlebek approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not make sure of the trace level. Perhaps we should document that it is exists, but explain that it is unused.

@hillaryfraley hillaryfraley merged commit e7afe27 into master Apr 28, 2020
@hillaryfraley hillaryfraley deleted the increment-log-level branch April 28, 2020 19:21
@hillaryfraley hillaryfraley removed the ready for review PR is ready to review label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echlebek echlebek echlebek approved these changes

Assignees

@hillaryfraley hillaryfraley

Labels
update Add to or refresh existing info
Projects
None yet
Milestone
5.20.0
Development

Successfully merging this pull request may close these issues.

Add commands for increasing log level at runtime
3 participants
@hillaryfraley @echlebek @cwjohnston