Avilable plugins as of 4-14-2014 did not work with solr1.4. My plugin ga... #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gathers same metrics as Pete Shima's plugins. Differences are I used nokogiri and CSS selectors to parse the XML. Allowing users to dynamically locate metrics and stats I feel work quite well in my plugin.
|
@mac-flanker can you please check Travis status? |
|
I have changed all of the tabs and spacing to conform to your style guide. On Wed, Apr 23, 2014 at 1:02 PM, Artem Chernikov
|
|
@mac-flanker thanks for your work. This is merged with upcoming plan to merge two checks into one to be version agnostic. |
kalabiyau
added a commit
that referenced
this pull request
Apr 27, 2014
Avilable plugins as of 4-14-2014 did not work with solr1.4. My plugin ga...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...thers same metrics as Pete Shima's plugins.
Differences are I used nokogiri and CSS selectors to parse the XML.
Allowing users to dynamically locate metrics and stats I feel work quite well in my plugin.
PS - I know the spacing looks off. I wrote using sublime text and changed the indentation to us 2 spaces as opposed to 4.