Fixed handler-slack-multichannel.rb #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
requested changes
Aug 17, 2017
lib/sensu-plugins-slack/version.rb
Outdated
| @@ -2,7 +2,7 @@ module SensuPluginsSlack | |||
| module Version | |||
| MAJOR = 1 | |||
| MINOR = 5 | |||
| PATCH = 0 | |||
| PATCH = 1 | |||
There was a problem hiding this comment.
please leave the versioning to maintainers as there is no guarantee on the order of released changes.
|
OK, reverted the version and added the changelog. |
majormoses
approved these changes
Aug 18, 2017
| @@ -4,6 +4,9 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachangelog.com/) | |||
|
|
|||
| ## [Unreleased] | |||
| ## [1.5.0] - 2017-08-18 | |||
There was a problem hiding this comment.
Ideally this should have been omitted as well but I will merge this anyways since everything else is right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Is this in reference to an existing issue?
General
Update Changelog following the conventions laid out on Keep A Changelog
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
New Plugins
Tests
Add the plugin to the README
Does it have a complete header as outlined here
Purpose
Slack uses one webhook_url per channel now! To support this, I have the configuration item "webhook_urls".
Known Compatablity Issues