Update aggregate plugins for Sensu 1.x #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
|
|
|
Deploying an RC gem build and doing some testing. |
|
|
majormoses
reviewed
Dec 18, 2018
| @@ -114,13 +107,6 @@ class CheckAggregate < Sensu::Plugin::Check::CLI | |||
| long: '--pattern PATTERN', | |||
| description: 'A PATTERN to detect outliers' | |||
|
|
|||
| option :honor_stash, | |||
There was a problem hiding this comment.
should we have honor_silence? I get that the api calls have been changed with the rename but I think we can still provide the same functionality right?
There was a problem hiding this comment.
Rework would be necessary to capture the client and check associated with particular named aggregate results (which probably requires a bunch of assumptions).
There was a problem hiding this comment.
OK, we just need to call that out as one of the breaking changes in the changelog then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Sensu Check Aggregate plugins for Sensu 1.x. This pull-request drops support for Sensu < 0.24.0, supporting only named aggregates.
Closes #19