Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slnx support #130

Merged
merged 4 commits into from
Feb 3, 2025
Merged

add slnx support #130

merged 4 commits into from
Feb 3, 2025

Conversation

sensslen
Copy link
Owner

@sensslen sensslen commented Dec 27, 2024

This PR is not yet fully complete, as msbuild does not yet support slnx files - at least in my local install

@sensslen sensslen marked this pull request as draft December 27, 2024 15:30
@sensslen sensslen force-pushed the simon/add-slnx-support branch 2 times, most recently from 7ae8f20 to 7ba90c2 Compare December 27, 2024 16:14
@pjmagee
Copy link

pjmagee commented Dec 27, 2024

I came across this, but not sure what needs to change dotnet/msbuild#10836

@sensslen
Copy link
Owner Author

sensslen commented Dec 27, 2024

I came across this, but not sure what needs to change dotnet/msbuild#10836

I'm pretty sure this change has not made it into a release yet... see dotnet/sdk#40913

@sensslen sensslen force-pushed the simon/add-slnx-support branch from 7ba90c2 to c6d89fd Compare December 29, 2024 12:19
@sensslen sensslen force-pushed the simon/add-slnx-support branch from c6d89fd to 8572600 Compare February 3, 2025 07:36
@sensslen sensslen force-pushed the simon/add-slnx-support branch from 8572600 to c38d3d0 Compare February 3, 2025 07:43
@sensslen sensslen force-pushed the simon/add-slnx-support branch 2 times, most recently from 2df8257 to 1cc1fa0 Compare February 3, 2025 07:53
@sensslen sensslen force-pushed the simon/add-slnx-support branch 2 times, most recently from 03c1bef to 2343742 Compare February 3, 2025 09:32
@sensslen sensslen force-pushed the simon/add-slnx-support branch from f4c2e63 to a50bc7b Compare February 3, 2025 12:49
Copy link

sonarqubecloud bot commented Feb 3, 2025

@sensslen sensslen marked this pull request as ready for review February 3, 2025 13:37
@sensslen sensslen merged commit 6606dcb into main Feb 3, 2025
37 of 42 checks passed
@sensslen sensslen deleted the simon/add-slnx-support branch February 3, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants