-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an account settings management helper object #70
Conversation
README.md
Outdated
@@ -81,6 +81,27 @@ puts response.status_code | |||
puts response.body | |||
puts response.headers | |||
``` | |||
## Manage Account Settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go in the README in the helper file, see the mail helper for an example: https://github.com/sendgrid/sendgrid-ruby/tree/master/lib/sendgrid/helpers/mail. Then you can link to it from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool makes sense, any preference on how I link to it from the main README? I didnt see a link to the mail helper there currently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current links are in-line like so:
- https://github.com/sendgrid/sendgrid-ruby/blob/master/examples/mail/mail.rb#L29
- https://github.com/sendgrid/sendgrid-ruby/blob/master/USAGE.md#v3-mail-send
But perhaps we can add a helpers section in the README too.
Very nice @kernkw! We just need some things to be moved around, please see the comments. Generally, please follow the conventions that the mail helper uses. Thanks! |
@thinkingserious it looks like this build is failing because its not exporting the env variables from the repo settings, my guess is that this because my pr is coming from a fork so when it builds the pr its not picking up those variables, i could be wrong but thats a theory This line is missing from my PR build and thus all of the tests are failing with 403 status code
|
@kernkw Correct, that is a known issue that will be fixed soon; meanwhile, you can test locally like this: #72 (comment) Thanks! |
@thinkingserious i am getting some test errors running the prism server, followed instructions and looked at the prism json i am not sure why the error is occurring, i pryed into the code to see what api call was failing. Basically i looks like prism is not reading integer params as integers but is receiving them as strings. Not sure what i am doing differently from you, i downloaded latest prism and pulled a fresh master branch from sendgrid-ruby
but when i remove the limit and offset param it works
|
I just tested your branch on my machine and that test passed. Can you please try these steps? Thanks! |
@thinkingserious ok cool it works thanks, i figured their website would download the latest version of prism but they have you download v0.1.2 so must have fixed the issue with their latest. I am gonna add rspec tests to run in the rake task, so travis CI can pick those up, sound good? |
Sounds good, thanks! |
Hi @kernkw, This one finally rose up to the top of the queue. Could you please fix the conflicts so that I may test and merge? Thanks! |
|
This PR should simplify the ability to retrieve or update account settings with just the name of the setting, instead of needing to know if a setting is a tracking, mail, user, or partner. This PR also pulls in rspec and faker gem to increase test thoroughness.
See example or readme for example.
Let me know your thoughts on this, I also have plans to add wrappers around other account management endpoints, such as subuser creation and management, stats, etc