Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #382] Correct endpoint for single spam report requests #383

Merged

Conversation

bermannoah
Copy link

@bermannoah bermannoah commented Feb 27, 2019

Fixes #382

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Updates the single spam report retrieval and deletion endpoints to be in line with the base API. https://sendgrid.com/docs/API_Reference/Web_API_v3/spam_reports.html#Get-a-specific-spam-report-GET and also updates the License dates.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Feb 27, 2019
@SendGridDX
Copy link

SendGridDX commented Feb 27, 2019

CLA assistant check
All committers have signed the CLA.

@bermannoah bermannoah changed the title Update spam report endpoint to reports Fix spam report endpoint for single report requests Feb 27, 2019
@bermannoah bermannoah changed the title Fix spam report endpoint for single report requests [Fixes #382] Correct endpoint for single spam report requests Feb 27, 2019
@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Feb 28, 2019
@thinkingserious thinkingserious merged commit d05f5b7 into sendgrid:master Feb 28, 2019
@thinkingserious
Copy link
Contributor

Hello @bermannoah,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@bermannoah
Copy link
Author

Hello @thinkingserious -- thanks for the quick merge! Glad I could help. :-)

@bermannoah bermannoah deleted the update-spam-reports-endpoint branch February 28, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect endpoints for single spam reports
3 participants