-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for dynamic template data. #300
Support for dynamic template data. #300
Conversation
This is awesome @nedcampion! Are you having an issue with our CLA? Is should be pretty quick and simple to get that signed, just need to click here and fill out a short form. Thanks! With Best Regards, Elmer |
I think I got it signed properly, but let me know if I missed something @thinkingserious. Also, I think this is going to fail the test suite (as the last PR did) because of three other tests that are failing. |
You got it @nedcampion! I'll get the other tests squared away :) |
Oh damn, I guess I should have checked here first. I just made a pull request for the same thing. Good on you, @nedcampion! |
Any chance this one is coming in soon? I'm very excited... 😁 |
Hello @lucaswhitman, I'm currently in the process of adding dynamic template support for all of our libraries, including Ruby. My apologies for the delay and unfortunately I don't have a solid ETA just yet. With Best Regards, Elmer |
@thinkingserious no worries, I'm pulling together a work around for now, just thought I'd check before committing to it. Thanks for the update! |
FWIW, I am doing this now with the current client with the method In the article, the |
@metaskills - thanks for the follow up! I'm walking down that road this morning and just sent my first successful test email. |
Hello @nedcampion, |
What's stopping this from being released? Last release Oct 2017! |
Hello @haffla, We now just have Java and Go coming up next before this one. It should not be much longer. With Best Regards, Elmer |
Can we have this released, please? |
Hi @Davidslv, Yes, this will be released soon. I'm close to releasing Java, then we will release Go and then I'll get this one out there. My apologies for the delay and thank you for your patience. With Best Regards, Elmer |
This is an initial take on adding support for newly added dynamic templates.
I've added an
add_dynamic_tempalte_data
method to thePersonalization
class as well as a test and some example code to show how it would be used.Fixes #300