-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a unittest to check the license.md file date range #250 #255
Conversation
@mbernier Right now the build is failing because LICENSE.txt year range is not updated. It is 2014-2016 as opposed to current year range 2014-2017 |
@prashuchaudhary I merged the conflicts, will come back and check on this in a bit. |
I am not seeing this test run - I know that the file checks are there and failing (this is expected and OK), is that preventing this test from running? Here's what I see:
Your test was added to `test_sendgrid-ruby.rb, but I don't see output saying that this specific test is failing:
|
and then .... it looks like the License file on your master branch is up to date with the 2017 - so it's working exactly as expected! I will go ahead and merge. Thank you! |
Hello @prashuchaudhary, |
Fixes #250
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.