-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
master: Use raw-string notation for regex to avoid invalid escape sequence #698
Conversation
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 85.04% 84.77% -0.28%
==========================================
Files 35 35
Lines 1157 1156 -1
Branches 172 172
==========================================
- Hits 984 980 -4
Misses 90 90
- Partials 83 86 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please rebase this against the v4 branch? Otherwise, LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase to v4.
Please see #727 as a replacement on the v4 branch. |
Checklist
Short description of what this PR does:
From the
re
docs:Before
After
$ pycodestyle | grep W605
Once merged, the exception from #654 should be removed:
https://github.com/sendgrid/sendgrid-python/pull/654/files#diff-354f30a63fb0907d4ad57269548329e3R35