Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace dynamic template data typehints #973

Merged
merged 4 commits into from
Jun 2, 2020
Merged

fix: Replace dynamic template data typehints #973

merged 4 commits into from
Jun 2, 2020

Conversation

kampalex
Copy link
Contributor

@kampalex kampalex commented Jun 2, 2020

Fixes

Fixes #917

Mail: replace type hint for class DynamicTemplateData to Substitution (referred class doesn't exists anymore)
BaseSendGridClientInterface: Updated type hints
Additionally:
BaseSendGridClientInterface: Converted to abstract class type (this class should not be instantiated, only subclasses of it)

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

kampalex added 4 commits May 19, 2020 15:38
@kampalex
Merge pull request #1 from sendgrid/master
d82606b 
Updated code base from upstream repository
@kampalex
Merge pull request #2 from sendgrid/master
b2520ac 
Update repository using sendgrid/master
@kampalex
Merge pull request #3 from sendgrid/master
a2e30cb 
Sync local repository using original
@kampalex
Fixes #917
060abcf 
Mail: replace type hint DynamicTemplateData to Substitution (referred class doesn't exists anymore)
BaseSendGridClientInterface: Updated type hints
Additionally:
BaseSendGridClientInterface: Converted to abstract class type (this class should not be instantiated, only subclasses of it)

Signed-off-by: Alexander Kamp <[email protected]>
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 2, 2020
thinkingserious
thinkingserious approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thinkingserious thinkingserious merged commit 2a55aac into sendgrid:master Jun 2, 2020
@kampalex kampalex deleted the fix-replace-DynamicTemplateData-typehints branch June 8, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHPDoc method prediction considerations
2 participants
@kampalex @thinkingserious