Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #788 - Add missing parameter for addCc and addBcc methods #837

Merged
merged 1 commit into from
May 21, 2019

Conversation

hjmsw
Copy link
Contributor

@hjmsw hjmsw commented May 10, 2019

Fixes #788

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Fixed missing parameter issue. Allows adding CC/BCC when passing a $personalizationIndex.
Example usage also included in KitchenSink example in another pull request: #836

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 10, 2019
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy labels May 21, 2019
@thinkingserious thinkingserious merged commit 53e7cd7 into sendgrid:master May 21, 2019
@thinkingserious
Copy link
Contributor

Hello @hjmsw,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio status: ready for deploy code ready to be released in next deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add BCC with $personalizationIndex
2 participants