Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add @throws to docblock #749

Merged
merged 2 commits into from
Mar 6, 2020
Merged

docs: add @throws to docblock #749

merged 2 commits into from
Mar 6, 2020

Conversation

iampoul
Copy link
Contributor

@iampoul iampoul commented Oct 17, 2018 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 17, 2018
peter279k
peter279k reviewed Oct 17, 2018
View reviewed changes
lib/mail/Asm.php Outdated Show resolved Hide resolved
peter279k
peter279k suggested changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@peter279k peter279k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some @throw block misses the TypeException namespace.

This should be changed :).

peter279k
peter279k approved these changes Oct 22, 2018 •
edited
Loading
View reviewed changes
peter279k
peter279k approved these changes Oct 22, 2018 •
edited
Loading
View reviewed changes
peter279k
peter279k approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@peter279k peter279k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@thinkingserious
Copy link
Contributor

Hello @iPoul,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@kampalex kampalex mentioned this pull request Dec 6, 2019
Closed
@childish-sambino childish-sambino changed the title add @throws to docblock docs: add @throws to docblock Mar 6, 2020
@childish-sambino childish-sambino merged commit c6e5511 into sendgrid:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

@peter279k peter279k peter279k approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iampoul @thinkingserious @peter279k @childish-sambino