Don't close <img> tag in HTML #514
Conversation
thinkingserious
added
the
status: code review request
|
|
examples/mail/mail.php
Outdated
| @@ -57,7 +57,7 @@ | |||
| "content": [ | |||
| { | |||
| "type": "text/html", | |||
| "value": "<html><p>Hello, world!</p><img src=[CID GOES HERE]></img></html>" | |||
| "value": "<html><p>Hello, world!</p><img src=[CID GOES HERE]></html>" | |||
There was a problem hiding this comment.
Should it have an internal forward slash, like so:
"value": "<html><p>Hello, world!</p><img src=[CID GOES HERE] /></html>"
There was a problem hiding this comment.
xhtmlish yes, html5 not necessary.
There was a problem hiding this comment.
/ are actually invalid, not facultative, in HTML 5. It's an XML only feature, and so only used on the old XHTML standard.
test/unit/SendGridTest.php
Outdated
| @@ -1096,7 +1096,7 @@ public function test_mail_send_post() | |||
| "content": [ | |||
| { | |||
| "type": "text/html", | |||
| "value": "<html><p>Hello, world!</p><img src=[CID GOES HERE]></img></html>" | |||
| "value": "<html><p>Hello, world!</p><img src=[CID GOES HERE]></html>" | |||
There was a problem hiding this comment.
Should it have an internal forward slash, like so:
"value": "<html><p>Hello, world!</p><img src=[CID GOES HERE] /></html>"
Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img "Tag omission: Must have a start tag and must not have an end tag."
dereckson
force-pushed
the
redundant-html-closing-tags
branch
from
fbdd946 to
87026f8
Compare
|
Hello @dereckson, |
|
You're welcome. Thanks for the swag. |
|
@dereckson Our agenda would be: Explore what you liked and is there anything we can do to improve? You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain. Thank you so much, Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager |
Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img
"Tag omission: Must have a start tag and must not have an end tag."