Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Incorrect value order in example array for addAttachments #1009

Merged
merged 1 commit into from
Oct 1, 2020
Merged

docs: Incorrect value order in example array for addAttachments #1009

merged 1 commit into from
Oct 1, 2020

Conversation

Anorris-NLR
Copy link
Contributor

Fixes

The file type and file name are in the wrong order for the $attachments array used in addAttachments. Used that way, files do not attach properly.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@Anorris-NLR
Update USE_CASES.md
397917f 
The file type and file name are in the wrong order for the $attachments array used in addAttachments. Used that way, files do not attach properly.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 29, 2020
thinkingserious
thinkingserious approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@thinkingserious thinkingserious added status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code and removed status: code review request requesting a community code review or review from Twilio labels Oct 1, 2020
@thinkingserious thinkingserious merged commit 7bdf97e into sendgrid:main Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anorris-NLR @thinkingserious