Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update README.md to explicitly state that 'send()' returns a promise #989

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

Ifunanyacollins
Copy link
Contributor

@Ifunanyacollins Ifunanyacollins commented Oct 7, 2019

explicitly stating that the send() method returns a promise

Fixes

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Twilio SendGrid, or file a Github Issue in this repository.

explicitly stating that the send() method returns a promise
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 7, 2019
@Ifunanyacollins Ifunanyacollins deleted the patch-1 branch October 7, 2019 04:56
@Ifunanyacollins Ifunanyacollins restored the patch-1 branch October 7, 2019 04:59
@Ifunanyacollins
Copy link
Contributor Author

@thinkingserious any clue why build is failing ?

@childish-sambino childish-sambino force-pushed the master branch 5 times, most recently from 389fa8c to 37473ad Compare January 15, 2020 21:44
@childish-sambino childish-sambino changed the title Update README.md docs: Update README.md to explicitly state that 'send()' returns a promise Feb 13, 2020
@childish-sambino childish-sambino merged commit de73e14 into sendgrid:master Feb 13, 2020
@thinkingserious
Copy link
Contributor

Hello @Ifunanyacollins,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants