Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow hiding warnings #932

Merged
merged 1 commit into from
May 20, 2019

Conversation

albertor24
Copy link
Contributor

@albertor24 albertor24 commented May 16, 2019

Fixes

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Description

  • Allows hiding warnings by using a "hideWarnings" parameter in the Mail class.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 16, 2019
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap and removed status: code review request requesting a community code review or review from Twilio labels May 20, 2019
@thinkingserious thinkingserious merged commit f07d7f5 into sendgrid:master May 20, 2019
@thinkingserious
Copy link
Contributor

Hello @albertor24,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@vieira
Copy link

vieira commented Aug 12, 2019

Hello, any idea when this will land on a release? We have our logs full of these warnings...

@Rowern
Copy link

Rowern commented Aug 22, 2019

@thinkingserious Any estimation for when this will get released ? This a pretty annoying thing, it breaks our log processor as it's not using our logger but a "dirty" console.warn...

@vieira
Copy link

vieira commented Sep 15, 2019

Hello @thinkingserious

Any idea when this will land? We have been waiting for months now having to manually set the sendgrid-helpers version to 6.3.0 in yarn.lock to avoid dirty logs!

Is there anything that still needs to be done before this can be released?

@sergiuds
Copy link

sergiuds commented Nov 1, 2019

Is this merged yet? It fills my logs with error and triggers my monitoring alerts :(

@andynunes
Copy link

Bah, I just spent a while trying to figure out why the hideWarnings options was not available in the latest version from npm. Bump for a soon release please! Thanks!

@childish-sambino
Copy link
Contributor

Releasing soon ...

@childish-sambino childish-sambino changed the title Allows hiding warnings feat: Allows hiding warnings Jan 15, 2020
@childish-sambino childish-sambino changed the title feat: Allows hiding warnings feat: Allow hiding warnings Jan 15, 2020
@Wtrapp
Copy link

Wtrapp commented May 28, 2020

hey @childish-sambino @thinkingserious is this fixed ?

@childish-sambino
Copy link
Contributor

@Wtrapp Yes.

@Wtrapp
Copy link

Wtrapp commented May 28, 2020

What version? @childish-sambino I'm using "@sendgrid/mail": "^7.0.0" with nodeJS and still getting the errors/warnings.

Content with characters ', " or & may need to be escaped with three brackets {{{ content }}} See https://sendgrid.com/docs/for-developers/sending-email/using-handlebars/ for more information.

Thanks for the quick response.

@childish-sambino
Copy link
Contributor

Should've been in 6.5.0. Are you passing the hideWarnings property? https://github.com/sendgrid/sendgrid-nodejs/blob/master/docs/use-cases/hide-warnings.md

@Wtrapp
Copy link

Wtrapp commented May 28, 2020

Of course I was not passing that property otherwise it would have been working perfectly.

Easy fix. Working great now. THANK YOU!!!

@sendgrid sendgrid locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants